Implement image pipeline #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-it
force-pushed
the
esommer/image_pipeline
branch
from
23a9cda to
6a05abe
Compare
Pokom
reviewed
Jan 29, 2024
|
Will work on adding the platform parameter today. Shouldn't take too long, hopefully 😄 |
dsotirakis
reviewed
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #80
The PR implements the image pipeline for cloudcost-exporter. It will not build the images pre merge, as the arm64 build takes 12 minutes currently. Instead we will execute all steps on merge and produce an image with every merged PR.
Small drive-by: I toke @zerok solution to detect the go version from the Dockerfile to build the tests.