Add datasource integration tests #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
malcolmholmes
commented
Mar 1, 2024
malcolmholmes
commented
- Almost working
- Final test passes
Comment on lines
+74
to
+75
| "datasource-broken-returned.json", | ||
| "datasource-broken-returned2.json", |
There was a problem hiding this comment.
I don't understand. Why is there the same file twice with a different name?
There was a problem hiding this comment.
because the subdir instance returns different data. But for now I've just excluded the subdir target for this test for this reason.
There was a problem hiding this comment.
I still don't understand why we don't use
ExpectedOutputFile: "datasource-broken-returned.json"
here 😅
malcolmholmes
force-pushed
the
malcolmholmes/datasource-integration-tests
branch
from
54419a6 to
6b8057a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.