Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Ubuntu 24.04 and 22.04 part 5/? #2030

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[CI] Ubuntu 24.04 and 22.04 part 5/? #2030

merged 3 commits into from
Oct 16, 2024

Conversation

woju
Copy link
Member

@woju woju commented Oct 14, 2024

Description of the changes

See #2026 for rationale

How to test this PR?

CI


This change is Reviewable

dimakuv
dimakuv previously approved these changes Oct 15, 2024
Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

@woju woju force-pushed the woju/noble-stack-3 branch 2 times, most recently from 6cf353c to 9d51894 Compare October 15, 2024 14:03
woju added 3 commits October 15, 2024 22:49
Piping straight to OUTPUT hid the error from the log, which made
diagnostics unwieldy in our CI.

Signed-off-by: Wojtek Porczyk <[email protected]>
Fixes: 03a42b0 ("[CI] Add pipeline for noble (Ubuntu 24.04 LTS)")
Fixes: 9d53dde ("[CI] Add pipeline for jammy (Ubuntu 22.04 LTS)")
Signed-off-by: Wojtek Porczyk <[email protected]>
@woju woju force-pushed the woju/noble-stack-4 branch from 2a9d374 to aff535f Compare October 15, 2024 20:49
Base automatically changed from woju/noble-stack-3 to master October 16, 2024 00:20
@mkow mkow dismissed dimakuv’s stale review October 16, 2024 00:20

The base branch was changed.

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow merged commit aff535f into master Oct 16, 2024
20 of 34 checks passed
@mkow mkow deleted the woju/noble-stack-4 branch October 16, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants