Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for double instantiation of GraphQLLocalExecutionClient #369

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

sungam3r
Copy link
Member

No description provided.

@sungam3r
Copy link
Member Author

@rose-a Tests are unstable. I managed to pass tests only for second attempt. Also I've noticed that github CI creates nuget packages twice - on the build and test steps.

@rose-a
Copy link
Collaborator

rose-a commented Oct 31, 2021

@rose-a Tests are unstable. I managed to pass tests only for second attempt. Also I've noticed that github CI creates nuget packages twice - on the build and test steps.

Yep, see #161, this seems to be some kind of threading issue with the way I'm trying to test the IObservable stuff, which also seems to depend on available system ressources (changes of passing are higher on a beefier machine, running the tests in question solitary on a development machine has almost 100% chance of passing... 😟

@rose-a rose-a merged commit 8cbe46e into master Oct 31, 2021
@rose-a rose-a deleted the fix-di branch October 31, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants