add terraform support for Teleport servers

[hugoShaka]

This PR implements: gravitational/teleport#37624

[marcoandredinis]

Did you test this?

I was testing for the openssh-ec2-ice nodes and it doesn't work if we give it a non-uuid string.

An example that works:

resource "random_uuid" "ec2-random-name" {
}

resource "teleport_server" "my-dev-server" {
  version  = "v2"
  sub_kind = "openssh-ec2-ice"
  metadata = {
    name = "${random_uuid.ec2-random-name.result}"
  }
  spec = {
    addr     = "<ec2 private ip>:22"
    hostname = "my-dev-server"
    cloud_metadata = {
      aws = {
        account_id  = "<account-id>"
        instance_id = "<instance-id>"
        region      = "<region>"
        vpc_id      = "<vpc-id>"
        integration = "<awsoidc-integration-used-for-credentials>"
        subnet_id   = "<subnet-id>"
      }
    }
  }
}

[hugoShaka]

Did you test this?

I was testing for the openssh-ec2-ice nodes and it doesn't work if we give it a non-uuid string.

Do you mean against a real AWS account? No, I only checked that Teleport was accepting the resource in the operator. I don't understand why the eice server name must be a uuid 🤔

[marcoandredinis]

It's a bit buried, but it is required to be an uuid because of this
https://github.com/gravitational/teleport/blob/a39c21716b40518f0433b619bb9828d127bd6b77/api/utils/route.go#L41

When I implemented EC2 ICE mode, I closely followed the OpenSSH/Agentless mode.
And I ended up making the same assumptions.

[tigrato]

I guess you shouldn't set the name. Instead, you should set the hostid.

Look at the condition here:

         _, err := uuid.Parse(host)
	dialByID := err == nil || aws.IsEC2NodeID(host)

[hugoShaka]

I updated the TF example to not set the name, and added tests for both named and nameless openssh servers.

[hugoShaka]

CheckAndSetDefaults and kind setting were moved before

id := {{.VarName}}Resource.Metadata.Name

because the name itself can be changed during this step (e.g. nameless openssh servers).

[marcoandredinis]

Just left a comment

[r0mant]

Bot.