This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Ensure kube_resources always have the correct defaults, even after version change #1043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required because relaxing the RequireReplace() causes the Kubernetes resource defaults bug to reappear.
For context:
We tried to solve this issue by marking the resource for replacement on version change, but this proved to be super disruptive. Not all resources can be deleted easily. AccessLists contain information about its members, and roles might have dependencies (you cannot delete a role if a user or an AL is referencing it, SSO are dynamic and we cannot remove them with TF).
This PR proposes a more advanced solution. Instead of using the TF state, we re-compute the defaults based on the configuration provided in the TF code. This is done with a Plan modifier.