Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gravity-forms/gw-prevent-duplicate-selections.js: Added support for GPADVS enabled multi-select fields. #733

Merged
merged 2 commits into from
Nov 30, 2023
Merged

gravity-forms/gw-prevent-duplicate-selections.js: Added support for GPADVS enabled multi-select fields. #733

merged 2 commits into from
Nov 30, 2023

Conversation

veryspry
Copy link
Contributor

Context

📓 Notion: https://www.notion.so/gravitywiz/GPADVS-1-1-Disabled-Choices-d910084a1ed24bd8947fdd6df242a2a9?pvs=4

Summary

This enabled support for this snippet on GPADVS enabled multi-select fields.

spivurno
spivurno approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly!

I think we should convert this to a PHP snippet for delivery though. More coming in the card. That decision won't impact merging this though. Fire away!

@veryspry veryspry merged commit 5bf2462 into master Nov 30, 2023
2 checks passed
@veryspry veryspry deleted the matt/prevent-default-support-gpadvs branch November 30, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spivurno spivurno spivurno approved these changes

@claygriffiths claygriffiths Awaiting requested review from claygriffiths

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veryspry @spivurno