Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated all references to String.prototype.format() to use String.prototype.gformFormat() as the former is removed in Gravity Forms 2.8. #737

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Updated all references to String.prototype.format() to use String.prototype.gformFormat() as the former is removed in Gravity Forms 2.8. #737

merged 2 commits into from
Dec 7, 2023

Conversation

spivurno
Copy link
Contributor

@spivurno spivurno commented Dec 7, 2023

Context

📓 Notion: https://www.notion.so/gravitywiz/GF-2-8-format-7fa6597679ea42b5b3d5123feb7ea077?pvs=4

Summary

PR title says it all. 😄

@spivurno
Updated all references to String.prototype.format() to use `String.…
8361d5d 
…prototype.gformFormat()` as the former is removed in Gravity Forms 2.8.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Fails
🚫

Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion.
🚫

Commit message 'Updated all references to String.prototype.format() to use String.prototype.gformFormat() as the former is removed in Gravity Forms 2.8.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.
🚫

Commit message '~ Restored previous function.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.
Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 09a4cf7

claygriffiths
claygriffiths requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! gw-populate-date.php uses Moment which has a .format() method that you won't want to replace.

gravity-forms/gw-populate-date.php Outdated Show resolved Hide resolved
gravity-forms/gw-populate-date.php Outdated Show resolved Hide resolved
gravity-forms/gw-populate-date.php Outdated Show resolved Hide resolved
claygriffiths
claygriffiths approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spivurno spivurno merged commit f61d124 into master Dec 7, 2023
1 of 3 checks passed
@spivurno spivurno deleted the dave/fix/gf-2.8 branch December 7, 2023 22:21
@spivurno spivurno mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claygriffiths claygriffiths claygriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spivurno @claygriffiths