Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpnf-set-created-by-property-on-child-entries-after-user-registration.php: Added snippet for GP Nested Forms that sets the created by property on the child entries after user account is created. #900

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sbassah
Copy link
Contributor

@sbassah sbassah commented Sep 30, 2024

Added new snippet for GP Nested Forms that sets the created by property on the child entries after user account is created.

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2719134672/71947/

Summary

When a nested form is submitted by a non-logged-in user, the created by property is not set on both the parent form entry and the child entries. However, when a, create user feed, is on the parent form to create a user account, it sets the created by property on the parent form but doesn't set that of the child form entries. This snippet sets the created by property on the child form entries, that is linked to the user registration parent form.

@spivurno spivurno requested review from spivurno and removed request for claygriffiths January 10, 2025 11:45
@spivurno
Copy link
Contributor

@sbassah Wanna get the PHP/Danger issues fixed up and we'll get this merged?

@saifsultanc saifsultanc force-pushed the sbassah-patch-1 branch 2 times, most recently from 7606302 to 4763aa1 Compare January 11, 2025 07:16
…n.php`: Added new snippet for GP Nested Forms that sets the created by property on the child entries after user account is created.
@saifsultanc saifsultanc changed the title `gpnf-set-created-by-property-on-child-entries-after-user-registratio… gpnf-set-created-by-property-on-child-entries-after-user-registration.php: Added snippet for GP Nested Forms that sets the created by property on the child entries after user account is created. Jan 11, 2025
@sbassah
Copy link
Contributor Author

sbassah commented Jan 15, 2025

@spivurno Sorry, I didn't see the tag earlier.

Saif has got the PHP/Danger issue sorted out, and it's ready for review.

@spivurno spivurno merged commit 905f889 into master Jan 15, 2025
5 checks passed
@spivurno spivurno deleted the sbassah-patch-1 branch January 15, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants