gpcp-product-pricing-labels.js
: Fixed an issue with decimal comma prices.
#998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2816007580/76520
Summary
Snippet is incorrectly handling values containing non-zero values after the comma for prices in Euros.
Steps to reproduce:
FORM SETUP:
BEFORE:
AFTER:
The snippet uses the Gravity Forms method
gformFormatMoney
, which is defined as :function gformFormatMoney(text, isNumeric){
. ThegformFormatMoney
relies oncurrency.toMoney(text, isNumeric)
.Current logic we have does not define
isNumeric
astrue
when callinggformFormatMoney
which causes the formatting issue with decimal comma currency values.