CMake: Set maximum supported Boost version #2788
Merged
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"find_package(Boost CONFIG)" finds the upstream package directly, without the find module. BoostConfig.cmake package configuration file is provided since Boost 1.70, so earlier versions couldn't be found.
Disable MSYS2 job because there are no trivial ways to install older Boost.
jamescowens
merged commit 9a62b1d
into
gridcoin-community:development
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CMakeLists and CI to use only Boost 1.86.0 and older. Fix "find_package" call so it works with Boost versions older than 1.70.
Upper bound could be removed after #2786 is finished.