Extended Syntax: case hoisting #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andorp
reviewed
Apr 15, 2020
|
|
||
| {- | ||
| IDEA: | ||
| If Alt had name then the HPT could calculate it's return type and store in TypeEnv |
There was a problem hiding this comment.
Alt has a name now. Maybe create an issue about it?
There was a problem hiding this comment.
Well, currently HPT tracks the alt name as a restricted version of the scrutinee. I will create an issue just for tracking this.
andorp
reviewed
Apr 15, 2020
| (freshAlt2, _) <- case cpat2 of | ||
| DefaultPat -> refreshNames nameMap alt2 | ||
| _ -> refreshNames nameMap $ EBind (SReturn $ Var freshLPatName) (VarPat altName2) alt2 | ||
| (freshAlt2, _) <- refreshNames nameMap $ |
There was a problem hiding this comment.
Now the default alt also has a name. It has to be rebound when hoisting the default alt into some other alt. See the default pattern test case.
andorp
approved these changes
Apr 15, 2020
csabahruska
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32