docs(post-message): update using-a-post-message #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gronxb
requested changes
Dec 21, 2024
docs/using-a-post-message.md
Outdated
| }, | ||
| eventName2: { | ||
| validate: (value) => data as { message: string }, // This is not recommended; please use validation libraries like zod or valibot. | ||
| validate: (value) => value as { message: string }, // This is not recommended; please use validation libraries like zod or valibot. |
There was a problem hiding this comment.
Thank you for noticing! Since eventName1 exists, could you unify it as data?
gronxb
changed the title
gronxb
reviewed
Dec 21, 2024
Co-authored-by: Sungyu Kang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this wonderful library. 🙇
While reading the "Using PostMessage" chapter, I noticed a few parts where I thought the code might not have been as the maintainer originally intended, so I made some modifications. I would appreciate it if you could review them.