Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all invalid mentions output to stderr #307

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Send all invalid mentions output to stderr #307

merged 1 commit into from
Feb 13, 2024

Conversation

zdrve
Copy link
Collaborator

@zdrve zdrve commented Feb 13, 2024

To ensure the "validate mentions" diagnostics come out in an understandable sequence.

It currently (example) says:

It generally means that you're trying to add a notification to somewhere for the first time
... (many lines later) ...
Invalid mentions found

which makes no sense. So change it to:

Invalid mentions found
...
It generally means that you're trying to add a notification to somewhere for the first time

Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grosser grosser merged commit 173b28d into master Feb 13, 2024
4 checks passed
@grosser grosser deleted the zdrve/err branch February 13, 2024 16:40
@grosser
Copy link
Owner

grosser commented Feb 13, 2024

v1.148.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants