Use a nil Descriptor list for empty proto files (#2152)

### Motivation: If a proto file contains no services we include a comment indicating this is expected. At the moment this has two empty lines above it. ### Modifications: Store `nil` instead of an empty array of `Descriptor`s into the `FileDescription`. ### Result: Only one empty line above the comment.
grpc · Jan 7, 2025 · 560c6c7 · 560c6c7
1 parent 5e92f64
commit 560c6c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Sources/GRPCCodeGen/Internal/Translator/IDLToStructuredSwiftTranslator.swift b/Sources/GRPCCodeGen/Internal/Translator/IDLToStructuredSwiftTranslator.swift
@@ -74,9 +74,9 @@ package struct IDLToStructuredSwiftTranslator: Translator {
       }
     }
 
-    let imports: [ImportDescription]
+    let imports: [ImportDescription]?
     if codeGenerationRequest.services.isEmpty {
-      imports = []
+      imports = nil
       codeBlocks.append(
         CodeBlock(comment: .inline("This file contained no services."))
       )

diff --git a/...RPCCodeGenTests/Internal/Translator/IDLToStructuredSwiftTranslatorSnippetBasedTests.swift b/...RPCCodeGenTests/Internal/Translator/IDLToStructuredSwiftTranslatorSnippetBasedTests.swift
@@ -145,7 +145,6 @@ final class IDLToStructuredSwiftTranslatorSnippetBasedTests: XCTestCase {
       """
       /// Some really exciting license header 2023.
 
-
       // This file contained no services.
       """
     try self.assertIDLToStructuredSwiftTranslation(
-Original file line number
+Diff line change
@@ Expand Up @@
           """
           /// Some really exciting license header 2023.
           // This file contained no services.
           """
         try self.assertIDLToStructuredSwiftTranslation(
@@ Expand Down @@