suggestion #3
Closed
suggestion #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tlambert03 thanks for the changeset, however it doesn't work seamlessly:
The issue is that by the time we reach this line, If we remove the |
|
yeah, i was never able to get that image to happen ... so I assumed I wasn't hitting it for some reason. I'll take another look |
gselzer
force-pushed
the
rgb-support
branch
13 times, most recently
from
165978f to
783dd39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think (but I'm not sure) that this swap of order in setup seems to work ok for the issue you mentioned in pyapp-kit#41 (comment) ... can you check?