-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the CAPI Multiple PaidFor template to Svelte #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-imber
force-pushed
the
ei/convert-capi-multiple-paidfor
branch
from
January 4, 2024 15:53
2f4490f
to
ce99528
Compare
Jakeii
reviewed
Jan 4, 2024
Jakeii
reviewed
Jan 4, 2024
Jakeii
reviewed
Jan 4, 2024
Jakeii
reviewed
Jan 4, 2024
Jakeii
reviewed
Jan 4, 2024
domlander
reviewed
Jan 8, 2024
Jakeii
reviewed
Jan 8, 2024
domlander
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Converts the CAPI Multiple PaidFor template to Svelte. Adds a template type variable to the CapiCard to make it usable in both the single and multiple templates. I've also added an extra breakpoint to the previews as I found it helpful whilst developing.
Images
Breakpoint - 360px
Svelte
Legacy
Breakpoint - 740px
Svelte
Legacy
Breakpoint - 980px
Svelte
Legacy
Breakpoint - 1300px
Svelte
Legacy