Improve error handling / logging #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log messages on Failures now include a summary of the underlying cause, if present. This should improve error visibility across the board in Security HQ. We also add additional error handling to the cache service. On every cache update we include a summary of which accounts have failures in their cache data.
adamnfish
force-pushed
the
add-more-logging-to-iam-credentials-report-code
branch
from
a459616 to
36d57a2
Compare
tjsilver
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages on Failures now include a summary of the underlying cause, if present. This should improve error visibility across the board in Security HQ.
We also add additional error handling to the cache service. On every cache update we include a summary of which accounts have failures in their cache data.
This is motivated by the IAM remediation issues, and will give us more information for digging into the problem.