fix: role assumption in production #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the v2 SDK migration, we have been incorrectly authenticatinng the STS Assume Role Credentials Provider used by security-hq when integrating with other AWS accounts. Instead of using the named Janus account profile (which will not exist in production), we omit the argument in order to use the default provider chain.
tjsilver
force-pushed
the
ts/af/fix-credentials-provider
branch
from
cf98897 to
281cca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Since the v2 SDK migration, we have been incorrectly authenticatinng the STS Assume Role Credentials Provider used by security-hq when integrating with other AWS accounts.
Instead of using the named Janus account profile (which will not exist in production), we omit the argument in order to use the default provider chain.