Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log account cloudbuster messages are sent to in PROD #1355

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tjsilver
Copy link
Contributor

@tjsilver tjsilver commented Dec 11, 2024

What does this change?

Adds the account ID of the target account to the console.log for cloudbuster.

Why?

In PROD, the log was still indicating that the messages were being sent to testing-alerts, when in fact they were going to the real accounts.

How has it been verified?

When this is merged, we should see real account IDs being logged out by cloudbuster PROD. I tested the CODE variant on CODE and the logging was as expected.

@tjsilver tjsilver requested review from a team as code owners December 11, 2024 17:18
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Separately, if we used logger this log line would appear with markers in Central ELK. Markers make graphing easier, for example.

@tjsilver tjsilver merged commit 70b8f77 into main Dec 12, 2024
7 checks passed
@tjsilver tjsilver deleted the ts/fix-cloudbuster-logging branch December 12, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants