Make singleton container readonly #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovemberTang
force-pushed
the
nt/more-readonly
branch
from
019bbf4 to
51949e5
Compare
akash1810
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Did we consider using the AWS CLI image plus some awk as a replacement for jq?
There was a problem hiding this comment.
We talked about this, but I think it represents an extra level of scope creep on a ticket that's already crept up massively, and could probably be a separate investigation.
NovemberTang
force-pushed
the
nt/more-readonly
branch
from
7462c69 to
b0dd129
Compare
Co-authored-by: Natasha <[email protected]>
NovemberTang
force-pushed
the
nt/more-readonly
branch
from
b0dd129 to
df4860f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a custom docker image for the singleton container, so we don't need to install awscli and jq.
Why?
This is part of the work to resolve AWS FSBP ECS.5 (No write access to root file system by default
How has it been verified?
Tested on CODE to verify expected behaviour for one job, and multiple concurrent ones.
What next
Create a reusable workflow for creating container images, as we now have 3 of these. This will be done in a follow-up PR