[Build] Rust dependency for tests #768
Conversation
We need the Rust toolchain installed now?
riedgar-ms
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 62.49% 69.02% +6.53%
==========================================
Files 55 55
Lines 4058 4058
==========================================
+ Hits 2536 2801 +265
+ Misses 1522 1257 -265 ☔ View full report in Codecov by Sentry. |
|
This was prompted by this CI failure This is to parallel your change to the GPU workflow @paulbkoch |
.github/workflows/ci_tests.yml
Outdated
| @@ -23,6 +23,12 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Install Rust | |||
| uses: actions-rs/toolchain@v1 | |||
There was a problem hiding this comment.
@paulbkoch according to:
https://github.com/actions-rs
this is no longer maintained?
There was a problem hiding this comment.
I'm seeing alternatives such as:
https://github.com/marketplace/actions/setup-rust-toolchain-for-github-ci
https://github.com/marketplace/actions/set-up-a-rust-toolchain
Would one of these be better @paulbkoch ?
|
Took a few goes, but this finally went through CI: |
| - name: Install Rust | ||
| shell: bash | ||
| run: | | ||
| curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain 1.75.0 |
There was a problem hiding this comment.
This was Michal's suggestion
|
Thanks @riedgar-ms! Sorry this was failing intermittently. I guess we got lucky on the PR build then. |
We need the Rust toolchain installed now. Take the opportunity to expand the context window on some tests, with the goal of making them fractionally more reliable.