-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Models] Add Phi3 to tests #776
[Models] Add Phi3 to tests #776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 55.37% 62.60% +7.22%
==========================================
Files 55 55
Lines 4074 4070 -4
==========================================
+ Hits 2256 2548 +292
+ Misses 1818 1522 -296 ☔ View full report in Codecov by Sentry. |
Hi, Here is my code: class Phi3Chat(TransformersChat, Transformers):
""" A HuggingFace transformers version of the Phi-3 Chat language model with Guidance support.
"""
def get_role_start(self, role_name, **kwargs):
role_dict = {
'user': "<|user|>\n",
'assistant': "<|assistant|>\n",
'system': "<|system|>\n"
}
return role_dict.get(role_name, '')
def get_role_end(self, role_name=None):
role_dict = {
'user': "<|end|>\n",
'assistant': "<|end|>\n",
'system': "<|end|>\n"
}
return role_dict.get(role_name, '') But this leads to tokenization error. |
Phi3 is now out, so start adding it into our testing frameworks