update yosys version #469
Merged
update yosys version #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gussmith23
requested changes
Sep 17, 2024
gussmith23
approved these changes
Sep 17, 2024
| && rm -rf /root/yosys | ||
| WORKDIR /root | ||
| RUN cd /root \ | ||
| && git clone https://github.com/YosysHQ/yosys.git \ |
There was a problem hiding this comment.
Can you add a comment here saying that Yosys depends on a submodule and so we cannot download an archive of it? Furthermore, say that, once dear-github/dear-github#214 is resolved, we could switch back to downloading an archive.
gussmith23
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
See my comment about merging #471 first -- Do that, then make sure the CI passes, and then please merge!
Thank you and great work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.