-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Jackson to v2.9.4 to resolve CVE-2017-15095 et al #67
Conversation
Awesome, thanks for this. One more request if you wouldn't mind; it appeared that both the 2.7 and 2.9 jar's were present in my logstash, even though 2.9 was the only one used. Would you be able to |
lib/jrjackson_jars.rb | ||
lib/com/fasterxml/jackson/ | ||
lib/jrjackson/jars/jrjackson-*.jar | ||
pom.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you want that in the .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think so. They are only needed during the package phase. AFACT they don't need to be in Github. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think I have covered that this time. The previous mechanism of gem files was From now on, the packaged gem published to rubygems should not have undesirable jars in it. |
Awesome, thank you. |
LGTM |
Thanks to @alex-dr for #66
The binaries and package only files are now not committed to the repo.
They will be packaged into the gem and pushed to rubygems by the author.