Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified the libs folder names. #416

Closed
wants to merge 1 commit into from

Conversation

keinhaar
Copy link
Contributor

@keinhaar keinhaar commented Dec 9, 2022

Renamed all "lib" folders to "libs", to be unique across all plugins.

Renamed all "lib" folders to "libs", to be unique.
@keinhaar
Copy link
Contributor Author

I've rebased.

@protoism
Copy link
Contributor

@keinhaar, I wonder, if we should just remove the binary artifacts from the repository, and go the maven way.

For sure .classpath files and .project files can be recreated correctly by a simple maven import.
For artifacts, it is a bit more tricky, but it should be possible.

Managing dependencies the way we're doing now is a bit of a nightmare

@keinhaar
Copy link
Contributor Author

Maybe, but i did not want to change the way things are done today. Just cleaning up.
If you can do it with maven, feel free to do it. I don't use maven very much. So i can't do that.

@protoism protoism added this to the 4.1 milestone Mar 3, 2023
@protoism
Copy link
Contributor

protoism commented Mar 3, 2023

Hi @keinhaar, I marked this for 4.1, as this PR is really cosmetic, i.e. no bug fixed, no real improvement... nothing that we "forgot" on 4.0.0.
I still wonder if we have to go all in with maven and remove all artifacts, but it requires time and patience...
So.. if we fix #454 this PR will simply be closed, otherwise it will go in for 4.1.
Let me know if my proposal makes sense and if this makes development too complicate on your side

@keinhaar
Copy link
Contributor Author

keinhaar commented Mar 3, 2023

if we fix #454 this PR will simply be closed, otherwise it will go in for 4.1.

Makes sense :-)

@protoism
Copy link
Contributor

This PR is a bit obsolete, as lots of dependencies are being removed.
I think that it's possible to remove all file JAR dependencies except gwt of course.

@protoism
Copy link
Contributor

Sorry for closing, but this PR is way less relevant now

@protoism protoism closed this Jul 26, 2024
@keinhaar keinhaar deleted the libfolders branch September 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants