Process distributions from SBML models #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the SBML processor to extract distributions from SBML models. Since distributions are not explicitly encoded in SBML, only as MathML expressions, we first convert MathML to SymPy and then map the name of the function representing the distribution and its arguments to ProbOnto. Generalization to a broader class of distributions can be done on a later PR. Distributions associated both with rate parameters and initial condition parameters are recognized.
The PR also adjusts Python versions for testing from 3.8-3.10 to 3.9-3.12. sbmlmath is nominally Python 3.10+ and works in practice on 3.9+, though not on 3.8 hence the version shift.
Fixes #361