Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "myterriblenfccard" #1403

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add "myterriblenfccard" #1403

wants to merge 22 commits into from

Conversation

JumpSushi
Copy link

@JumpSushi JumpSushi commented Jan 9, 2025

Submission Checklist:

  • [ X] I am a current high school, middle school, or home schooled student.

  • I have joined the #electronics channel on Slack

  • [ X] I made this board from scratch, even if I followed a tutorial

  • [ X] I have followed the directions in README.md

    • [ X] Created a folder under onboard/projects
    • [X ] Filled out TEMPLATE.md as README.md inside your project folder
    • [ X] Uploaded gerber.zip and schematic.pdf inside your project folder
    • [ X] Created a folder called src and uploaded design files
    • [ X] Uploaded screenshot of PCB order called cart.png with all costs included
    • [X ] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [ X] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • [X ] (Optional) This project is from a tutorial1.

  • (Optional) This project is for OnBoard Live2.

  • (Optional) This project is for Hacky Holidays3.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

  2. OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack!

  3. Hacky Holidays is a limited time PCB event, design a holiday-themed PCB this Winter, and get it shipped.

@github-actions github-actions bot added the Submission New Boards! label Jan 9, 2025
@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Jan 9, 2025

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/myterriblenfccard:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf Manually check schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@LimesKey LimesKey self-assigned this Jan 10, 2025
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nice PCB, it is not terrible. However, having a large copper layer near the antenna is not recommended and may cause it not to work. Are you able to shrink the bottom copper filled layer's size or will you take the risk?
image
The pink shouldn't be touching the blue antenna

@JumpSushi
Copy link
Author

Hello, thank you for your review. I'll shrink the pink area you mentioned then. Thank you so much!

@JumpSushi JumpSushi requested a review from LimesKey January 10, 2025 13:52
@JumpSushi
Copy link
Author

Hello, I've updated the PCB, Gerber, and cart with the new changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants