Redesign of the newsletter section! #955
Conversation
There was a problem hiding this comment.
It seems to me that there are a large number of changes in this PR relating to formatting that do not relate to the actual redesign that was the cause for the PR in the first place. Can these formatting changes be done as a separate diff to clearly delineate where the feature begins/ends vs the other changes to ;'s, "'s, and whitespace?
|
Hey @grymmy! Just removed the formatting. |
|
@maxwofford have also fixed corner radius + padding issues! |
Bumps [@octokit/auth-app](https://github.com/octokit/auth-app.js) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/octokit/auth-app.js/releases) - [Commits](octokit/auth-app.js@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: "@octokit/auth-app" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.10 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…/auth-app-6.0.1
…raverse-7.23.2
Update team.js
| import CardModel from './card-model' | ||
| import BGImg from '../../background-image' | ||
| import FooterImgFile from '../../../public/home/footer.png' | ||
| import Icon from "@hackclub/icons"; |
There was a problem hiding this comment.
Did you mean to switch this to single quote, semicolon lines?
components/mail-card.js
Outdated
| }} | ||
| > | ||
| <Box sx={{ px: [3, 4] }}> | ||
| <Box> |
There was a problem hiding this comment.
Lots of nesting in this area-- are all these <Box>s needed?
| import BGImg from "../../background-image"; | ||
| import background from "../../../public/home/footer.png"; | ||
| import MailCard from "../../mail-card"; | ||
| import { format } from "date-fns"; |
There was a problem hiding this comment.
Most of our pages list local files imports below npm imports
…tter-redesign # Conflicts: # yarn.lock
|
Awesome! Go for merge |
No description provided.