Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for digit fluctuation in mdscoring integration tests #1185

Merged
merged 1 commit into from
Dec 16, 2024
Merged

allow for digit fluctuation in mdscoring integration tests #1185

merged 1 commit into from
Dec 16, 2024

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Dec 16, 2024

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Allow for 0.01 digit fluctuation when comparing haddock score and per-interface score in integration-tests/test_mdscoring.py.

Related Issue

Closes #1184

@VGPReys VGPReys self-assigned this Dec 16, 2024
@VGPReys VGPReys added the enhancement Enhancing an existing feature of adding a new one label Dec 16, 2024
@VGPReys VGPReys requested a review from mgiulini December 16, 2024 09:06
@VGPReys VGPReys merged commit 7b2dc54 into main Dec 16, 2024
7 checks passed
@VGPReys VGPReys deleted the fix-mdscoring-integration-test-rounding-check branch December 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiulini mgiulini mgiulini approved these changes

Assignees

@VGPReys VGPReys

Labels
enhancement Enhancing an existing feature of adding a new one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometime error when running test_mdscoring.py
2 participants
@VGPReys @mgiulini