[ci] Dont tar the hail wheel in CI pipelines #13912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
approved these changes
Oct 25, 2023
|
WIP until I sort the release. |
daniel-goldstein
force-pushed
the
no-wheel-container-tar
branch
from
1ee2712 to
e5bcbe1
Compare
jmarshall
added a commit
to populationgenomics/hail
that referenced
this pull request
Nov 10, 2023
Upstream's hail-is#13912 changed this to copy a .whl file in a subdirectory around, instead of tarring/untarring it for no real reason.
cassimons
pushed a commit
to populationgenomics/hail
that referenced
this pull request
Nov 10, 2023
Upstream's hail-is#13912 changed this to copy a .whl file in a subdirectory around, instead of tarring/untarring it for no real reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC the reason we
tarthe hail wheel to move it between jobs in the CI pipeline is because the wheel name must contain the pip version and that is not known statically inbuild.yaml. However, it would be just as effective to copy the wheel around inside a directory, and then we don't have to do all this tar'ing and untar'ing.cc @ehigham I'm happy to hold off on this if it would bork your branch