chore: HIP-755 - add post implementation updates for accuracy #1098
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Luke Lee <[email protected]>
david-bakin-sl
changed the title
david-bakin-sl
approved these changes
Jan 17, 2025
| This supports the prior acquisition of signatures and their future submission, as often utilized in direct HAPI transaction submissions. | ||
| In order to validate the signatures in the signature map for the `signSchedule(address, bytes)` function call, | ||
| a message has to be agreed upon. The most logical message would be the concatenated values of the shard, realm and number of the schedule transaction ID and this value will be used | ||
| by convention. | ||
|
|
||
| To support safe and easy direct calls by an EOA in accordance with the security model, new facade methods will be added as part of this HRC 755. |
There was a problem hiding this comment.
This is the only use of "HRC" in this file. Is it supposed to be "HIP"? Or if "HRC" then also spell out the acronym somewhere (footnote)?
Comment on lines
+62
to
+64
| In order to validate the signatures in the signature map for the `signSchedule(address, bytes)` function call, | ||
| a message has to be agreed upon. The most logical message would be the concatenated values of the shard, realm and number of the schedule transaction ID and this value will be used | ||
| by convention. |
There was a problem hiding this comment.
These last two sentences are less "specification" (the section name) and more "suggestion to developers". Especially the last sentence. I don't suggest moving them elsewhere, but maybe they should be subordinate in some way, e.g., a bullet point?
(This is me ratholing on style again, sorry.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update several details in HIP-755 to better reflect the actual implementation.