Implement stable hashCode for records.

pbj-integration-tests/build.gradle.kts

@@ -81,6 +81,9 @@ jmh {
 //    includes.add("AccountDetailsBench")
 //    includes.add("JsonBench")
 //    includes.add("VarIntBench")
+//    includes.add("HashBench")
+//    includes.add("EqualsHashCodeBench");
+
     jmhVersion.set("1.35")
     includeTests.set(true)
 //    jvmArgsAppend.add("-XX:MaxInlineSize=100 -XX:MaxInlineLevel=20")

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/EqualsHashCodeBench.java

@@ -0,0 +1,62 @@
+package com.hedera.pbj.intergration.jmh;
+
+import com.google.protobuf.CodedInputStream;
+import com.google.protobuf.CodedOutputStream;
+import com.hedera.pbj.intergration.test.TestHashFunctions;
+import com.hedera.pbj.runtime.MalformedProtobufException;
+import com.hedera.pbj.runtime.io.buffer.BufferedData;
+import com.hedera.pbj.runtime.io.buffer.Bytes;
+import com.hedera.pbj.runtime.io.stream.ReadableStreamingData;
+import com.hedera.pbj.test.proto.pbj.Hasheval;
+import com.hedera.pbj.test.proto.pbj.Suit;
+import com.hedera.pbj.test.proto.pbj.TimestampTest;
+import com.hedera.pbj.test.proto.pbj.tests.HashevalTest;
+import org.openjdk.jmh.annotations.*;
+import org.openjdk.jmh.infra.Blackhole;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.nio.*;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+@SuppressWarnings("unused")
+@State(Scope.Benchmark)
+@Fork(1)
+@Warmup(iterations = 4, time = 2)
+@Measurement(iterations = 5, time = 2)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@BenchmarkMode(Mode.AverageTime)
+public class EqualsHashCodeBench {
+    private TimestampTest testStamp;
+    private TimestampTest testStamp1;
+
+    public EqualsHashCodeBench() {
+        testStamp = new TimestampTest(987L, 123);
+        testStamp1 = new TimestampTest(987L, 122);
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(1050)
+    public void benchHashCode(Blackhole blackhole) throws IOException {
+        for (int i = 0; i < 1050; i++) {
+            testStamp.hashCode();
+        }
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(1050)
+    public void benchEquals(Blackhole blackhole) throws IOException {
+        for (int i = 0; i < 1050; i++) {
+            testStamp.equals(testStamp);
+        }
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(1050)
+    public void benchNotEquals(Blackhole blackhole) throws IOException {
+        for (int i = 0; i < 1050; i++) {
+            testStamp.equals(testStamp1);
+        }
+    }
+}

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/HashBench.java

@@ -0,0 +1,56 @@
+package com.hedera.pbj.intergration.jmh;
+
+import com.google.protobuf.CodedInputStream;
+import com.google.protobuf.CodedOutputStream;
+import com.hedera.pbj.intergration.test.TestHashFunctions;
+import com.hedera.pbj.runtime.MalformedProtobufException;
+import com.hedera.pbj.runtime.io.buffer.BufferedData;
+import com.hedera.pbj.runtime.io.buffer.Bytes;
+import com.hedera.pbj.runtime.io.stream.ReadableStreamingData;
+import com.hedera.pbj.test.proto.pbj.Hasheval;
+import com.hedera.pbj.test.proto.pbj.Suit;
+import com.hedera.pbj.test.proto.pbj.TimestampTest;
+import com.hedera.pbj.test.proto.pbj.tests.HashevalTest;
+import org.openjdk.jmh.annotations.*;
+import org.openjdk.jmh.infra.Blackhole;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.nio.*;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+@SuppressWarnings("unused")
+@State(Scope.Benchmark)
+@Fork(1)
+@Warmup(iterations = 4, time = 2)
+@Measurement(iterations = 5, time = 2)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@BenchmarkMode(Mode.AverageTime)
+public class HashBench {
+    private Hasheval hasheval;
+
+    public HashBench() {
+        TimestampTest tst = new TimestampTest(987L, 123);
+        hasheval = new Hasheval(1, -1, 2, 3, -2,
+                                123f, 7L, -7L, 123L, 234L,
+                                -345L, 456.789D, true, Suit.ACES, tst, "FooBarKKKKHHHHOIOIOI",
+                                 Bytes.wrap(new byte[]{1, 2, 3, 4, 5, 6, 7, (byte)255}));
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(1050)
+    public void hashBenchSHA256(Blackhole blackhole) throws IOException {
+        for (int i = 0; i < 1050; i++) {
+            TestHashFunctions.hash1(hasheval);
+        }
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(1050)
+    public void hashBenchFieldWise(Blackhole blackhole) throws IOException {
+        for (int i = 0; i < 1050; i++) {
+            TestHashFunctions.hash2(hasheval);
+        }
+    }
+}

pbj-integration-tests/src/main/proto/hasheval.proto

@@ -0,0 +1,34 @@
+syntax = "proto3";
+
+package proto;
+
+option java_package = "com.hedera.pbj.test.proto.java";
+option java_multiple_files = true;
+// <<<pbj.java_package = "com.hedera.pbj.test.proto.pbj">>> This comment is special code for setting PBJ Compiler java package
+
+import "timestampTest.proto";
+import "google/protobuf/wrappers.proto";
+import "everything.proto";
+
+/**
+ * Example protobuf containing examples of all types
+ */
+message Hasheval {
+  int32 int32Number = 1;
+  sint32 sint32Number = 2;
+  uint32 uint32Number = 3;
+  fixed32 fixed32Number = 4;
+  sfixed32 sfixed32Number = 5;
+  float floatNumber = 6;
+  int64 int64Number = 7;
+  sint64 sint64Number = 8;
+  uint64 uint64Number = 9;
+  fixed64 fixed64Number = 10;
+  sfixed64 sfixed64Number = 11;
+  double doubleNumber = 12;
+  bool booleanField = 13;
+  Suit enumSuit = 14;
+  TimestampTest subObject = 15;
+  string text = 16;
+  bytes bytesField = 17;
+}

pbj-integration-tests/src/main/proto/timestampTest2.proto

@@ -0,0 +1,62 @@
+syntax = "proto3";
+
+package proto;
+
+/** Test issue 87 */
+/** Test issue 87 */
+
+/*-
+ * ‌
+ * Hedera Network Services Protobuf
+ * ​
+ * Copyright (C) 2018 - 2021 Hedera Hashgraph, LLC
+ * ​
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ‍
+ */
+
+option java_package = "com.hedera.pbj.test.proto.java";
+option java_multiple_files = true;
+// <<<pbj.java_package = "com.hedera.pbj.test.proto.pbj">>> This comment is special code for setting PBJ Compiler java package
+
+/**
+ * An exact date and time. This is the same data structure as the protobuf Timestamp.proto (see the
+ * comments in https://github.com/google/protobuf/blob/master/src/google/protobuf/timestamp.proto)
+ */
+message TimestampTest2 {
+  /**
+   * Number of complete seconds since the start of the epoch
+   */
+  int64 seconds = 1;
+
+  /**
+   * Number of nanoseconds since the start of the last second
+   */
+  int32 nanos = 2;
+
+  /**
+   * Number of picoseconds since the start of the last nanosecond
+   */
+  int32 pico = 3;
+}
+
+/**
+ * An exact date and time,  with a resolution of one second (no nanoseconds).
+ */
+message TimestampTestSeconds2 {
+  /**
+   * Number of complete seconds since the start of the epoch
+   */
+  int64 seconds = 1;
+}
+

pbj-integration-tests/src/test/java/com/hedera/pbj/intergration/test/HashEqualsTest.java

@@ -0,0 +1,90 @@
+package com.hedera.pbj.intergration.test;
+
+import org.junit.jupiter.api.Test;
+
+import com.hedera.pbj.test.proto.pbj.TimestampTest;
+import com.hedera.pbj.test.proto.pbj.TimestampTest2;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class HasjhEqualsTest {
+    @Test
+    void differentObjectsWithDefaulEquals() {
+        TimestampTest tst = new TimestampTest(1, 2);
+        TimestampTest2 tst2 = new TimestampTest2(1, 2, 0);
+
+        assertFalse(tst.equals(tst2));
+    }
+
+    @Test
+    void sameObjectsWithNoDefaulEquals() {
+        TimestampTest tst = new TimestampTest(3, 4);
+        TimestampTest tst1 = new TimestampTest(3, 4);
+
+        assertEquals(tst, tst1);
+    }
+
+    @Test
+    void sameObjectsWithDefaulNoEquals() {
+        TimestampTest tst = new TimestampTest(3, 4);
+        TimestampTest tst1 = new TimestampTest(3, 5);
+
+        assertNotEquals(tst, tst1);
+    }
+
+    @Test
+    void sameObjectsWithDefaulEquals() {
+        TimestampTest tst = new TimestampTest(0, 0);
+        TimestampTest tst1 = new TimestampTest(0, 0);
+
+        assertEquals(tst, tst1);
+    }
+
+    @Test
+    void differentObjectsWithDefaulHashCode() {
+        TimestampTest tst = new TimestampTest(0, 0);
+        TimestampTest2 tst2 = new TimestampTest2(0, 0, 0);
+
+        assertEquals(tst.hashCode(), tst2.hashCode());
+    }
+
+    @Test
+    void differentObjectsWithNoDefaulHashCode() {
+        TimestampTest tst = new TimestampTest(1, 0);
+        TimestampTest2 tst2 = new TimestampTest2(1, 0, 0);
+
+        assertEquals(tst.hashCode(), tst2.hashCode());
+    }
+
+    @Test
+    void differentObjectsWithNoDefaulHashCode1() {
+        TimestampTest tst = new TimestampTest(0, 0);
+        TimestampTest2 tst2 = new TimestampTest2(0, 0, 3);
+
+        assertNotEquals(tst.hashCode(), tst2.hashCode());
+    }
+
+    @Test
+    void differentObjectsWithNoDefaulHashCode2() {
+        TimestampTest2 tst = new TimestampTest2(0, 0, 0);
+        TimestampTest2 tst2 = new TimestampTest2(0, 0, 0);
+
+        assertEquals(tst.hashCode(), tst2.hashCode());
+    }
+
+    @Test
+    void differentObjectsWithNoDefaulHashCode3() {
+        TimestampTest2 tst = new TimestampTest2(1, 2, 3);
+        TimestampTest2 tst2 = new TimestampTest2(1, 2, 3);
+
+        assertEquals(tst.hashCode(), tst2.hashCode());
+    }
+
+    @Test
+    void differentObjectsWithNoDefaulHashCode4() {
+        TimestampTest2 tst = new TimestampTest2(1, 4, 3);
+        TimestampTest2 tst2 = new TimestampTest2(1, 2, 3);
+
+        assertNotEquals(tst.hashCode(), tst2.hashCode());
+    }
+}