Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run spotless on all files in pbj-core #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsync-swirlds
Copy link
Member

This is the result of running gradle spotlessApply with ratchet disabled.
This reformats many files to match Heiro code style standards.
There are no logic or other code changes included.

Note, this PR is against an ancestor branch for now to support review, and may retarget to main after the predecessor PR is merged.

@jsync-swirlds jsync-swirlds self-assigned this Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

JUnit Test Report

   67 files  +   67     67 suites  +67   2m 33s ⏱️ + 2m 33s
1 265 tests +1 265  1 262 ✅ +1 262   3 💤 + 3  0 ❌ ±0 
7 120 runs  +7 120  7 101 ✅ +7 101  19 💤 +19  0 ❌ ±0 

Results for commit 37dea7b. ± Comparison against base commit 31fdb7d.

♻️ This comment has been updated with latest results.

@jsync-swirlds jsync-swirlds force-pushed the pbj-core-reformat-test branch from df72aaf to 9a5592a Compare January 17, 2025 04:57
jasperpotts
jasperpotts previously approved these changes Jan 17, 2025
Copy link
Member

@jasperpotts jasperpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the effort on this :-)

Base automatically changed from fix-pbj-core-spotless to main January 17, 2025 23:04
@jsync-swirlds jsync-swirlds dismissed jasperpotts’s stale review January 17, 2025 23:04

The base branch was changed.

@jsync-swirlds jsync-swirlds force-pushed the pbj-core-reformat-test branch 3 times, most recently from 9126e62 to 9e9aa6b Compare January 17, 2025 23:12
@jsync-swirlds jsync-swirlds force-pushed the pbj-core-reformat-test branch from 9e9aa6b to 37dea7b Compare January 17, 2025 23:16
@jsync-swirlds jsync-swirlds marked this pull request as ready for review January 17, 2025 23:17
@jsync-swirlds jsync-swirlds requested review from a team as code owners January 17, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants