Add support for team notification configurations #1016

jfreda · 2024-12-05T17:50:37Z

Description

This PR adds support for team notification configurations.

External links

API documentation

Output from tests

$ ENABLE_BETA=1 go test ./... -run 'TestTeamNotificationConfiguration' -v
=== RUN   TestTeamNotificationConfigurationList
=== RUN   TestTeamNotificationConfigurationList/with_a_valid_team
    team_notification_configuration_integration_test.go:43: paging not supported yet in API
=== RUN   TestTeamNotificationConfigurationList/with_list_options
    team_notification_configuration_integration_test.go:49: paging not supported yet in API
=== RUN   TestTeamNotificationConfigurationList/without_a_valid_team
--- PASS: TestTeamNotificationConfigurationList (1.88s)
    --- SKIP: TestTeamNotificationConfigurationList/with_a_valid_team (0.15s)
    --- SKIP: TestTeamNotificationConfigurationList/with_list_options (0.00s)
    --- PASS: TestTeamNotificationConfigurationList/without_a_valid_team (0.00s)
=== RUN   TestTeamNotificationConfigurationCreate
=== RUN   TestTeamNotificationConfigurationCreate/with_all_required_values
=== RUN   TestTeamNotificationConfigurationCreate/without_a_required_value
=== RUN   TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_generic
=== RUN   TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_slack
=== RUN   TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_MS_Teams
=== RUN   TestTeamNotificationConfigurationCreate/without_a_valid_team
=== RUN   TestTeamNotificationConfigurationCreate/with_an_invalid_notification_trigger
=== RUN   TestTeamNotificationConfigurationCreate/with_email_users_when_destination_type_is_email
=== RUN   TestTeamNotificationConfigurationCreate/without_email_users_when_destination_type_is_email
--- PASS: TestTeamNotificationConfigurationCreate (3.11s)
    --- PASS: TestTeamNotificationConfigurationCreate/with_all_required_values (0.15s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_a_required_value (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_generic (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_slack (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_a_required_value_URL_when_destination_type_is_MS_Teams (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_a_valid_team (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/with_an_invalid_notification_trigger (0.00s)
    --- PASS: TestTeamNotificationConfigurationCreate/with_email_users_when_destination_type_is_email (0.21s)
    --- PASS: TestTeamNotificationConfigurationCreate/without_email_users_when_destination_type_is_email (0.19s)
=== RUN   TestTeamNotificationConfigurationsCreate_byType
=== PAUSE TestTeamNotificationConfigurationsCreate_byType
=== RUN   TestTeamNotificationConfigurationRead
=== RUN   TestTeamNotificationConfigurationRead/with_a_valid_ID
=== RUN   TestTeamNotificationConfigurationRead/when_the_notification_configuration_does_not_exist
=== RUN   TestTeamNotificationConfigurationRead/when_the_notification_configuration_ID_is_invalid
--- PASS: TestTeamNotificationConfigurationRead (1.94s)
    --- PASS: TestTeamNotificationConfigurationRead/with_a_valid_ID (0.16s)
    --- PASS: TestTeamNotificationConfigurationRead/when_the_notification_configuration_does_not_exist (0.11s)
    --- PASS: TestTeamNotificationConfigurationRead/when_the_notification_configuration_ID_is_invalid (0.00s)
=== RUN   TestTeamNotificationConfigurationUpdate
=== RUN   TestTeamNotificationConfigurationUpdate/with_options
=== RUN   TestTeamNotificationConfigurationUpdate/with_invalid_notification_trigger
=== RUN   TestTeamNotificationConfigurationUpdate/with_email_users_when_destination_type_is_email
=== RUN   TestTeamNotificationConfigurationUpdate/without_email_users_when_destination_type_is_email
=== RUN   TestTeamNotificationConfigurationUpdate/without_options
=== RUN   TestTeamNotificationConfigurationUpdate/when_the_notification_configuration_does_not_exist
=== RUN   TestTeamNotificationConfigurationUpdate/when_the_notification_configuration_ID_is_invalid
--- PASS: TestTeamNotificationConfigurationUpdate (6.76s)
    --- PASS: TestTeamNotificationConfigurationUpdate/with_options (0.73s)
    --- PASS: TestTeamNotificationConfigurationUpdate/with_invalid_notification_trigger (0.00s)
    --- PASS: TestTeamNotificationConfigurationUpdate/with_email_users_when_destination_type_is_email (0.21s)
    --- PASS: TestTeamNotificationConfigurationUpdate/without_email_users_when_destination_type_is_email (0.20s)
    --- PASS: TestTeamNotificationConfigurationUpdate/without_options (0.39s)
    --- PASS: TestTeamNotificationConfigurationUpdate/when_the_notification_configuration_does_not_exist (0.14s)
    --- PASS: TestTeamNotificationConfigurationUpdate/when_the_notification_configuration_ID_is_invalid (0.00s)
=== RUN   TestTeamNotificationConfigurationDelete
=== RUN   TestTeamNotificationConfigurationDelete/with_a_valid_ID
=== RUN   TestTeamNotificationConfigurationDelete/when_the_notification_configuration_does_not_exist
=== RUN   TestTeamNotificationConfigurationDelete/when_the_notification_configuration_ID_is_invalid
--- PASS: TestTeamNotificationConfigurationDelete (2.22s)
    --- PASS: TestTeamNotificationConfigurationDelete/with_a_valid_ID (0.30s)
    --- PASS: TestTeamNotificationConfigurationDelete/when_the_notification_configuration_does_not_exist (0.13s)
    --- PASS: TestTeamNotificationConfigurationDelete/when_the_notification_configuration_ID_is_invalid (0.00s)
=== RUN   TestTeamNotificationConfigurationVerify
=== RUN   TestTeamNotificationConfigurationVerify/with_a_valid_ID
=== RUN   TestTeamNotificationConfigurationVerify/when_the_notification_configuration_does_not_exists
=== RUN   TestTeamNotificationConfigurationVerify/when_the_notification_configuration_ID_is_invalid
--- PASS: TestTeamNotificationConfigurationVerify (2.33s)
    --- PASS: TestTeamNotificationConfigurationVerify/with_a_valid_ID (0.39s)
    --- PASS: TestTeamNotificationConfigurationVerify/when_the_notification_configuration_does_not_exists (0.12s)
    --- PASS: TestTeamNotificationConfigurationVerify/when_the_notification_configuration_ID_is_invalid (0.00s)
=== CONT  TestTeamNotificationConfigurationsCreate_byType
=== RUN   TestTeamNotificationConfigurationsCreate_byType/with_trigger_change_request:created_and_all_required_values
=== PAUSE TestTeamNotificationConfigurationsCreate_byType/with_trigger_change_request:created_and_all_required_values
=== CONT  TestTeamNotificationConfigurationsCreate_byType/with_trigger_change_request:created_and_all_required_values
--- PASS: TestTeamNotificationConfigurationsCreate_byType (1.74s)
    --- PASS: TestTeamNotificationConfigurationsCreate_byType/with_trigger_change_request:created_and_all_required_values (0.14s)
PASS
ok  	github.com/hashicorp/go-tfe	20.447s

…ture is GA

jfreda · 2024-12-11T01:07:15Z

A fix for the linting error might be kind of weird IMO, but I can do it if any reviewers feel strongly about it (I saw in CONTRIBUTING.md that linting is not strictly required for these to pass; not sure if this would require an ignore to not be noisy in CI).

datadog-terraform-cloud-hashicorp · 2024-12-16T20:07:47Z

Datadog Report

Branch report: jfreda/add-team-notification-configs
Commit report: 330b3de
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 159 Skipped, 17m 45.78s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.1%)

…patched jsonapi

go.mod

…l subscribable

notchairmk · 2025-01-02T21:36:34Z

notification_configuration_integration_test.go

@@ -34,13 +34,16 @@ func TestNotificationConfigurationList(t *testing.T) {
 		assert.Contains(t, ncl.Items, ncTest1)
 		assert.Contains(t, ncl.Items, ncTest2)

-		t.Skip("paging not supported yet in API")


Removed the skips for these tests. They work even though we don't really support pagination for these endpoints (we cap at 20 notification configurations maximum per subscribable).

run_trigger.go

…1027) Prerequisite for #1016. Bumps the jsonapi version to address a bug with interactions between `polyrelation` and deprecated `relation`. Updates run triggers to backfill the deprecated Sourceable field in the RunTrigger struct.

…ication-configs

notification_configuration.go

github-actions · 2025-01-08T20:24:18Z

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Add support for team notification configurations

87e4bef

jfreda requested a review from a team December 5, 2024 17:50

jfreda requested a review from a team as a code owner December 5, 2024 17:50

jfreda mentioned this pull request Dec 7, 2024

Add tfe_team_notification_configuration resource hashicorp/terraform-provider-tfe#1540

Open

2 tasks

Add skipUnlessBeta to team notification configuration tests until fea…

07477b9

…ture is GA

use plus feature set

b5ede4b

notchairmk mentioned this pull request Dec 23, 2024

fix: handle deprecating relation for polyrelation hashicorp/jsonapi#27

Merged

move team notifications to notification configuration resources, use …

57017b9

…patched jsonapi

notchairmk reviewed Dec 23, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

notchairmk added 3 commits January 2, 2025 12:15

update NC interface signatures, omit deprecated subscribable, backfil…

bd9a54b

…l subscribable

update notification configuration mock signatures

22a0415

fix tests, update run triggers to handle deprecated in the same way

e4e84f5

notchairmk reviewed Jan 2, 2025

View reviewed changes

run_trigger.go Outdated Show resolved Hide resolved

move create validation to valid receiver

fc1e263

notchairmk mentioned this pull request Jan 7, 2025

chore(deps): bump jsonapi, update RunTrigger use deprecated relation #1027

Merged

notchairmk added 2 commits January 7, 2025 13:25

Merge remote-tracking branch 'origin/main' into jfreda/add-team-notif…

3b68b95

…ication-configs

run go mod tidy

518ceb0

brandonc previously approved these changes Jan 8, 2025

View reviewed changes

notification_configuration.go Outdated Show resolved Hide resolved

omitempty when creating notification subscribable choice

bb7b35f

notchairmk dismissed brandonc’s stale review via bb7b35f January 8, 2025 18:24

brandonc approved these changes Jan 8, 2025

View reviewed changes

notchairmk merged commit 7b0ffc9 into main Jan 8, 2025
7 checks passed

notchairmk deleted the jfreda/add-team-notification-configs branch January 8, 2025 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for team notification configurations #1016

Add support for team notification configurations #1016

jfreda commented Dec 5, 2024 •

edited

Loading

jfreda commented Dec 11, 2024

datadog-terraform-cloud-hashicorp bot commented Dec 16, 2024 •

edited

Loading

notchairmk Jan 2, 2025

github-actions bot commented Jan 8, 2025

Add support for team notification configurations #1016

Add support for team notification configurations #1016

Conversation

jfreda commented Dec 5, 2024 • edited Loading

Description

External links

Output from tests

jfreda commented Dec 11, 2024

datadog-terraform-cloud-hashicorp bot commented Dec 16, 2024 • edited Loading

Datadog Report

notchairmk Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2025

jfreda commented Dec 5, 2024 •

edited

Loading

datadog-terraform-cloud-hashicorp bot commented Dec 16, 2024 •

edited

Loading