[TF-18527] Add Archs to AdminTerraformVersionCreateOptions

[natalie-todd]

Description

The purpose of this PR is to update the AdminTerraformVersionCreateOptions struct with an Archs field so Terraform Releases can add Terraform versions with Linux amd64 and arm64 architectures.

External links

• API documentation
• Related PR
• Jira

[datadog-terraform-cloud-hashicorp]

Datadog Report

Branch report: ntodd/tf-18527/support-tool-version-architectures
Commit report: bf8719c
Test service: hashicorp/go-tfe

✅ 0 Failed, 1419 Passed, 153 Skipped, 21m 47.33s Total Time
➡️ Test Sessions change in coverage: 1 no change

[sebasslash]

Thanks for adding this! A few blocking things before we merge:

• We should add tests to admin_terraform_version_integration_test.go to ensure this new field is behaving as expected when we create/update a version.
• Please add a changelog entry under the # Unreleased section
• See comment below

Thank you 👍

[natalie-todd]

Thanks for adding this! A few blocking things before we merge:

• We should add tests to admin_terraform_version_integration_test.go to ensure this new field is behaving as expected when we create/update a version.
• Please add a changelog entry under the # Unreleased section
• See comment below

Thank you 👍

Hi @sebasslash, I think I addressed these bullet points but let me know if there is anything else I'm missing. Thanks!

[radditude]

A couple of very minor questions, but this makes sense to me as a first pass to enable basic usage of the create endpoint while the feature is still flagged!

[radditude]

Question for core cloud folks: do we need to note that this is in beta to give any TFE users a heads up that they won't be able to use that field yet?

[uturunku1]

Thank you, yes! In the past we have used words like: Adds BETA support for [such and such feature], which is EXPERIMENTAL, SUBJECT TO CHANGE, and may not be available to all users.
Those words could be applied here.

[radditude]

Do we want to add a validation that checks all fields are provided for architectures, if present? I could also make a case for waiting to add that handling along with update support once the feature is released and the API is fully stable!

[natalie-todd]

I just added a validation to check whether at least one valid arch was provided or a valid URL and SHA. Let me know if this seems good or if you were thinking of something else.

[radditude]

That's perfect! Just a little nicer to skip making the request if we already know it's going to fail.

Natalie addressed the changes requested by Sebastian

[github-actions]

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.