fix: handling non reschedule disconnecting and reconnecting allocs#18701

Merged

Juanadelacuesta merged 27 commits intomainfrom b-gh-16515

Oct 27, 2023

+536-236

Commits on Oct 24, 2023

style: change how the error is handled, for clarity, no functional changes
Juanadelacuesta
committed
func: take into account untaited disconnecting allocs to add at the final count, to avoid generating replacements for non reschedulable allocs
Juanadelacuesta
committed
style: simplify function, no functional change at all
Juanadelacuesta
committed
func: avoid returning filterByRescheduleable if an untainted alloc hhas not be checked to be rescheduled now or later
Juanadelacuesta
committed
func: refactor filterByReschedulable for clarity, no functional updates
Juanadelacuesta
committed
func: Update reconcile util functions to properly handle reconnecting allocs
Juanadelacuesta
committed
func: put back the resrtiction of not disconneting to let the createTimeoutLaterEvals handle those
Juanadelacuesta
committed
func: when there are unknow allocs, dont ignore them, because they will be rescheduled, set them as untainted
Juanadelacuesta
committed
func: update test to reflect change in behaviour for unknown allocs
Juanadelacuesta
committed
style: refactor functions for clarity, no functional updates
Juanadelacuesta
committed
style: change how the error is handled, for clarity, no functional changes
Juanadelacuesta
committed
style: function name change, for clarity, no functional changes
Juanadelacuesta
committed
func: use the last event to calculate the rescheduling time, not the alloc now, because they will never match
Juanadelacuesta
committed
func: dont try to remove allocs with uknown status
Juanadelacuesta
committed
func: filter out unknown allocs from final count to avoid stoping allocs because there are too many
Juanadelacuesta
committed
fix: create a copy of untainted allocs and filter that one, because the untainted are still used in the rest of the reconciliation
Juanadelacuesta
committed
fix: refactor filterByRescheduleable to avoid having allocs that can be both rescheduledNow and untainted
Juanadelacuesta
committed
func: fix the logic for the expired allocation
Juanadelacuesta
committed
func: stopped allocations from a dissconnectable client need to be ignored, so they dont add in the final count and wont cause other allocations to be stopped
Juanadelacuesta
committed
func: add extra condition of using max disconnect client hen deciding if ignore or ack an stoped allocation
Juanadelacuesta
committed
fix: fix the condition for early return on next schedule time, it has to be attempts==0 and unlimited == false
Juanadelacuesta
committed

Commits on Oct 25, 2023

Commits on Oct 26, 2023

fix: add correct alloc states and previous eval ID to disconnected allocs, to avoid replacing them by empty follow up eval
Juanadelacuesta
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handling non reschedule disconnecting and reconnecting allocs#18701

Commits on Oct 24, 2023

style: change how the error is handled, for clarity, no functional changes

func: take into account untaited disconnecting allocs to add at the final count, to avoid generating replacements for non reschedulable allocs

style: simplify function, no functional change at all

func: avoid returning filterByRescheduleable if an untainted alloc hhas not be checked to be rescheduled now or later

func: refactor filterByReschedulable for clarity, no functional updates

func: Update reconcile util functions to properly handle reconnecting allocs

func: put back the resrtiction of not disconneting to let the createTimeoutLaterEvals handle those

func: when there are unknow allocs, dont ignore them, because they will be rescheduled, set them as untainted

func: update test to reflect change in behaviour for unknown allocs

style: refactor functions for clarity, no functional updates

style: change how the error is handled, for clarity, no functional changes

style: function name change, for clarity, no functional changes

func: use the last event to calculate the rescheduling time, not the alloc now, because they will never match

func: dont try to remove allocs with uknown status

func: filter out unknown allocs from final count to avoid stoping allocs because there are too many

fix: create a copy of untainted allocs and filter that one, because the untainted are still used in the rest of the reconciliation

fix: refactor filterByRescheduleable to avoid having allocs that can be both rescheduledNow and untainted

func: fix the logic for the expired allocation

func: stopped allocations from a dissconnectable client need to be ignored, so they dont add in the final count and wont cause other allocations to be stopped

func: add extra condition of using max disconnect client hen deciding if ignore or ack an stoped allocation

fix: fix the condition for early return on next schedule time, it has to be attempts==0 and unlimited == false

Commits on Oct 25, 2023

fix: change the logic for alloc replacement detection to using the allocID and nextAllocID, also update the tests for desconnecting to account for the 2 new evals that are created, one the spin the…

func: avoid restoping stopped allocs, by checking the state before adding them to the updates

func: add extra condition to elegible later allocs, so allocs that have been previously replaced can be replaced again

fix: update tests to not count stopped allocs as updates and correctly count untainted and reconnected using the adecuate alloc replacememnt logic

fix: update the filter by tainted function to ignore allocs that need to be rescheduled and set as untanted the ones that dont

Commits on Oct 26, 2023

fix: add correct alloc states and previous eval ID to disconnected allocs, to avoid replacing them by empty follow up eval