[ui] Signing in with a token explicitly sets the region dropdown activeRegion #24347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
LGTM, thanks @philrenaud!
I think it's also worthy of a changelog and backport.
Ember Test Audit comparison
|
shoenig
approved these changes
Nov 1, 2024
philrenaud
force-pushed
the
24337-ui-blank-region-identifier-when-logging-into-federated-cluster
branch
from
4cab9b5 to
0de52bc
Compare
philrenaud
force-pushed
the
24337-ui-blank-region-identifier-when-logging-into-federated-cluster
branch
from
0de52bc to
d80d17c
Compare
philrenaud
deleted the
24337-ui-blank-region-identifier-when-logging-into-federated-cluster
branch
philrenaud
added a commit
that referenced
this pull request
Nov 2, 2024
* ui: show region in header gutter when only one region exists This PR adds a plain text label of the region to the header when there is only one region present. Before, nothing was showin in this case, and a dropdown was shown on federated clusters. The use case here is for operators of multiple non-federated Nomad clusters, when all the UI's involved otherwise look identical. * [ui] Signing in with a token explicitly sets the region dropdown activeRegion (#24347) * Signing in with a token explicitly sets the region dropdown activeREgion * Test and Select a Region default text * Account for 403 on mocked agent members req * Dont show the region if it isnt set in agent config * Small padding css change * unit test condition moved to stubbable acceptance test --------- Co-authored-by: Phil Renaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to @shoenig's work in #24320 so branching off of that
As it stands, when you sign in with a token in a multi-region cluster, the
system.regionsarray exists, but thesystem.activeRegiondoesn't re-compute.This makes that value recompute automatically during token verification, and refreshes the regions list to trigger that.
(Note: I don't think this is an issue for SSO-based authentication, since there is an explicit page refresh, which would handle region-setting by virtue of initial page load)
Resolves #24337