Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ui: Fill service check background object for pending checks. into release/1.9.x #24866

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #24818 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


Fills the service check marker with a grey when in pending state, whereas it was previously empty. I personally found the empty space a little confusing at first glance, whereas having this addition makes it obvious what is happening with the check and that you can hover and see the status.

I chose the colour based on a quick look, trying to find a grey that wasn't too dark, but I don't really know what I am doing, so please let me know what changes to make.

I think it makes sense to backport. Let me know if you think I should add a changelog entry.

Before:
image

After:
image

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-ui-service-check-pending-background-fill/cleanly-famous-glider branch from 1acacda to 634c7bf Compare January 15, 2025 15:27
@vercel vercel bot temporarily deployed to Preview – nomad-ui January 15, 2025 15:31 Inactive
@jrasell jrasell merged commit 3e94dd5 into release/1.9.x Jan 15, 2025
12 of 18 checks passed
@jrasell jrasell deleted the backport/b-ui-service-check-pending-background-fill/cleanly-famous-glider branch January 15, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants