-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[F-net-11478] Make keys directory cluster grouped #24883
Open
Juanadelacuesta
wants to merge
6
commits into
main
Choose a base branch
from
f-NET-11478-keys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanadelacuesta
force-pushed
the
f-NET-11478-keys
branch
2 times, most recently
from
January 16, 2025 22:11
9b161a6
to
1629913
Compare
Juanadelacuesta
added
backport/ent/1.9.x+ent
Changes are backported to 1.9.x+ent
backport/1.9.x
backport to 1.9.x release line
and removed
backport/ent/1.9.x+ent
Changes are backported to 1.9.x+ent
labels
Jan 16, 2025
Juanadelacuesta
force-pushed
the
f-NET-11478-keys
branch
from
January 16, 2025 22:17
1629913
to
7776501
Compare
tgross
previously approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Tim Gross <[email protected]>
tgross
previously approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Juanadelacuesta
force-pushed
the
f-NET-11478-keys
branch
from
January 17, 2025 15:54
01d5601
to
5ca1c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the adjustments to use the e2e terraform provisioning as a module and to be able to run multiple clusters concurrently, all the TLS and SSH resources need to be placed in a different folder so they are not overwritten by running the same module multiple times, this PR introduces a folder per cluster for all TLS, SSH and bootstratp tokens used during provisioning.
It also expands the usage of the
instance_arch
to windows machines.Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.