Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Ensure logger set up method is public. #24886

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 17, 2025

This is needed by a Nomad Enterprise code path.

Initially changed within: #24873

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

This is needed by a Nomad Enterprise code path.
@jrasell jrasell added the backport/1.9.x backport to 1.9.x release line label Jan 17, 2025
@jrasell jrasell self-assigned this Jan 17, 2025
@jrasell jrasell requested review from a team as code owners January 17, 2025 08:24
@jrasell jrasell merged commit 63ea13b into main Jan 17, 2025
33 checks passed
@jrasell jrasell deleted the f-agent-remove-log-filter-public-logger-setup branch January 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants