fix: required argument for aws_s3_bucket_lifecycle_configuration incorrectly set as optional

[mvandenburgh]

Description

The rule.noncurrent_version_expiration.noncurrent_days field was marked as optional in both the TF provider code and docs, but it is actually required by the AWS API.

The AWS docs are not 100% clear on this, but attempting to create a aws_s3_bucket_lifecycle_configuration without this field will result in this error:

Error: creating S3 Lifecycle Configuration for bucket (<bucket_name>):
InvalidArgument: 'NoncurrentDays' for NoncurrentVersionExpiration action
must be a positive integer status code: 400, request id: <>, host id: <>

Additionally, here is a screenshot of the AWS console UI that is used to create this resource:

You can clearly see that the "Days after objects become noncurrent" (noncurrent_days) value is required, while "Number of newer versions to retain" (newer_noncurrent_versions) is optional.

Relations

Closes #35328

References

AWS docs

Output from Acceptance Testing

% make testacc TESTS=TestAccS3BucketLifecycleConfiguration PKG=s3

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @mvandenburgh 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃