feat: Add resource network_interface_permission (WIP)

[justinrlee]

WIP: DO NOT MERGE

Description

Creating this PR for sharing purposes; still need to build tests and update documentation

Creates the network_interface_permission TF resource (corresponds to AWS CLI command aws ec2 create-network-interface-permission).

Has been functionally tested but needs to be completed.

Reference API: CreateNetworkInterfacePermission

Relations

Closes #40802

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @justinrlee 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[justinrlee]

Hello! Here's a question for those who might know:

This creates a resource that is only available in certain whitelisted AWS accounts (it allows you to grant another account access to an ENI; the grantee account must be whitelisted by AWS). If the target account is not whitelisted, you'll see an error message like this:

Error: creating EC2 Network Interface Permission: operation error EC2: CreateNetworkInterfacePermission, https response error StatusCode: 400, RequestID: 147a1a20-3cc8-4dc9-8840-36e3627a4607, api error OperationNotPermitted: The account 443332222111 is not permitted to receive cross account permissions.

This means that in my personal testing of the acceptance tests, it works*, but I'm guessing the acceptance test(s) run by the Hashicorp build-and-deploy infra will not work. How should we approach this?

* I'm still working on getting the disappears acceptance test to work; when I do a manual "disappear" test everything works but the acceptance test does not. Functionally the resource works.