Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_directory_service_directory: added launch_time, os_version #40934

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link

@ivankatliarchuk ivankatliarchuk commented Jan 15, 2025

Description

Add Computed attributes to aws_directory_service_directory

  • launch_time
  • os_version
  • stage_last_updated_date_time

Relations

Closes #31009

References

API reference not much use
Requested to update documentation as well for this page https://docs.aws.amazon.com/directoryservice/latest/devguide/API_DirectoryDescription.html

OS Version only available for Microsoft

Screenshot 2025-01-15 at 00 33 42
Screenshot 2025-01-15 at 00 33 35
Screenshot 2025-01-15 at 00 33 28

Output from Acceptance Testing

% make testacc TESTS=TestAccDSDirectory_basic PKG=ds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ds/... -v -count 1 -parallel 20 -run='TestAccDSDirectory_basic'  -timeout 360m -vet=off
2025/01/15 00:29:57 Initializing Terraform AWS Provider...
=== RUN   TestAccDSDirectory_basic
=== PAUSE TestAccDSDirectory_basic
=== CONT  TestAccDSDirectory_basic
--- PASS: TestAccDSDirectory_basic (588.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	600.955s
...
% make testacc TESTS=TestAccDSDirectory_desiredNumberOfDomainControllers PKG=ds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ds/... -v -count 1 -parallel 20 -run='TestAccDSDirectory_desiredNumberOfDomainControllers'  -timeout 360m -vet=off
2025/01/15 00:46:33 Initializing Terraform AWS Provider...
=== RUN   TestAccDSDirectory_desiredNumberOfDomainControllers
=== PAUSE TestAccDSDirectory_desiredNumberOfDomainControllers
=== CONT  TestAccDSDirectory_desiredNumberOfDomainControllers
--- PASS: TestAccDSDirectory_desiredNumberOfDomainControllers (4204.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	4216.703s
...

…stage_last_updated_date_time

Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk ivankatliarchuk requested a review from a team as a code owner January 15, 2025 09:25
@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 15, 2025 09:25
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ds Issues and PRs that pertain to the ds service. needs-triage Waiting for first response or review from a maintainer. labels Jan 15, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review January 15, 2025 19:12
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 15, 2025
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ds Issues and PRs that pertain to the ds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Computed attributes to aws_directory_service_directory
2 participants