-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add price_performance_target param onto aws provider #40946
base: main
Are you sure you want to change the base?
Add price_performance_target param onto aws provider #40946
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I would specifically like feedback on if we just feel it's better to ignore the nested attributes and just assume enabled if specifying the level. I was back and forth on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @cr-klarna 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
687ebce
to
2e585a2
Compare
Description
Change introduces a way to configure price_performance_target values on a serverless workgroup. Some important notes on differences to the AWS API:
enables
nested attribute to improve terraform semantics vs thestatus
field in the API (set to string "ENABLED" or "DISABLED" which is clunky when declaring config)base_capacity
being set if price_performance_target.enabled is true.example:
Relations
Closes #40915
References
Output from Acceptance Testing