Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller Config TTLs Options For Boundary Cluster Resource/Data #1164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RyanDerr
Copy link
Member

@RyanDerr RyanDerr commented Jan 6, 2025

🛠️ Description

  • Added new optional input values for configuring the controller's auth_token_time_to_live and auth_token_time_to_stale in a valid duration string (following time.Duration standards`
    • auth_token_time_to_live defaults to 7 days
    • auth_token_time_to_stale defaults to 1 day
    • When specifying either new attribute the other is required along side.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/webhook/validator (cached) [no tests to run]
=== RUN   TestAccBoundaryCluster
--- PASS: TestAccBoundaryCluster (149.94s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      150.526s
...

@RyanDerr RyanDerr force-pushed the ICU-15929 branch 6 times, most recently from 41ee583 to e645643 Compare January 6, 2025 21:27
@RyanDerr RyanDerr self-assigned this Jan 7, 2025
@RyanDerr RyanDerr force-pushed the ICU-15929 branch 3 times, most recently from 1fd3433 to 7eecd03 Compare January 7, 2025 15:28
@RyanDerr RyanDerr force-pushed the ICU-15929 branch 4 times, most recently from 8187747 to 0ab786d Compare January 8, 2025 15:37
@RyanDerr RyanDerr force-pushed the ICU-15929 branch 6 times, most recently from 0dc8c72 to 046a1cb Compare January 9, 2025 16:02
@RyanDerr RyanDerr marked this pull request as ready for review January 9, 2025 16:05
@RyanDerr RyanDerr requested review from a team as code owners January 9, 2025 16:05
@RyanDerr RyanDerr changed the title ICU-15929 Add Controller Config TTLs Options For Boundary Cluster Resource/Data Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants