Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lessc dependencies to trigger re-renders #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bhagany
Copy link
Contributor

@bhagany bhagany commented Jan 21, 2018

It turns out that lessc has a relatively easy way of tracking dependencies for the files that it compiles, and we can leverage this to know when to recompile at a granular level. There are no user-facing api changes.

@arichiardi
Copy link
Collaborator

@bhagany first of all thanks as usual for working on this.

The patch achieves reloading of imported files, like .variables and .overrides for Semantic UI.
There is a problem though: at the end of the pipeline I see the following and the main css file does not seem to be updated:

Process completed successfully.
[lessc] - copied unchanged file public/css/blog.css
Sifting output files...

@arichiardi
Copy link
Collaborator

arichiardi commented Apr 11, 2018

This still has the problem described, seems like a simple fix, will do my best to check that

@allentiak allentiak self-requested a review February 28, 2019 04:50
Copy link
Contributor

@allentiak allentiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just explicitly mentioning previous comments...)

The patch achieves reloading of imported files, like .variables and .overrides for Semantic UI.
There is a problem though: at the end of the pipeline I see the following and the main css file does not seem to be updated:

Process completed successfully.
[lessc] - copied unchanged file public/css/blog.css
Sifting output files...

@arichiardi
Copy link
Collaborator

Will have to check this, after one year I forgot about it and of course it is a very nice to have 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants