-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust for new additions in upcoming random-1.3 #89
Conversation
3100be7
to
4a351dc
Compare
197ed8d
to
2696732
Compare
|
I think, I'll need to add both random 1.2 and random 1.3 to build matrix |
@Shimuuar Very good question. There are two approaches that can be taken. One is implemented in #96 That approach is efficient, but it would not work for seed being compatible between big-endian and littel-endian machines and it requires a newer version of There is an alternative version I am planning to submit a PR for as well, that will be simpler and will work just as well regardless of endianness, but it will be slowe, since it will have to go through a list. I was really waiting for this PR to be merged and |
FYI @Shimuuar I am working on fixing up this PR to pass CI |
915f27a
to
2321a3d
Compare
RE |
Yeah, I've seen that. We can do normalization by the means of I only implemented that instance so far as a proof of concept, just to make sure the new |
Looks like there is also a need for a lower bound revision on hackage for |
GHC versions that could not handle `<$>` and `<*>` without extra `Functor` and `Applicative` constraints are no longer supported.
25a75b3
to
7068658
Compare
Update upper bound for doctest to include a version that works with ghc-9.12
7068658
to
1dc6256
Compare
I think this PR is ready to go. |
I think PR is good to go. @lehins thanks! We still need to test both random-1.2 and 1.3 on CI. But that could be done separatelu |
Hey @Shimuuar I am working on some changes in the
random-1.3
stateful interface in haskell/random#153 Could you take a look and see if you find it sensible.Addition of
modifyGen
is more useful for stateful generators that are regular wrappers aroundRandomGen
rather than for the ones like mwc implements. It also allows for a mutableGen
to be overwritten with theSeed
usingoverwriteGen