为什么不可以这样写呢？ #76
Open
为什么不可以这样写呢？ #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for (E e : c)
if (add(e))
modified = true;
return modified;
是因为addAll调用了add的原因，所以用addAll会导致两次求和
|
🎉 感谢提交Pull Request！请稍等片刻，我们已经将其提交到CI进行检查，一旦有结果会立即通知您！ |
|
你的提交 6cb0169 ，似乎失败了：Your tests failed on CircleCI 😅 请不要气馁，仔细分析原因，再接再厉！ |
|
@blindpirate @hcsp-bot 为什么这样写会通不过呢。。。。emmm感觉这样的话emm |
hcsp-bot
reviewed
Oct 25, 2019
| @@ -4,26 +4,27 @@ | |||
| import java.util.Collection; | |||
| import java.util.HashSet; | |||
|
|
|||
| public class CountingSet extends HashSet<Object> { | |||
| public class CountingSet extends HashSet{ | |||
There was a problem hiding this comment.
不明白这里为什么要把范型去掉。虽然跟你碰到的问题无关，但是我还是想问，你去掉范型的意图是什么？
There was a problem hiding this comment.
这个忘了给它写回去。。。。不小心把整个行都删掉了
hcsp-bot
reviewed
Oct 25, 2019
| public class CountingSet extends HashSet<Object> { | ||
| public class CountingSet extends HashSet{ | ||
|
|
||
| private HashSet<Object> set = new HashSet<>(); |
There was a problem hiding this comment.
你现在在“混用”组合和继承，这是大忌，因为你很难搞清楚，调用的方法究竟是“自己的”，还是“自己肚子里的另外一个对象的”。就比如说你现在碰到的问题，调用CountingSet的size()方法，究竟是在调用CountingSet本身的size()方法（继承自HashSet）呢，还是在调用CountingSet中的set的size()方法呢？
如果你不是对组合和继承的原理非常了解，请不要混用它们。
There was a problem hiding this comment.
好的，就是说一般情况下不建议这样用嘛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blindpirate
@hcsp-bot