English fixes and minor code tidyup #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiglandreas
requested changes
Jul 9, 2019
| @@ -65,7 +65,7 @@ public function bind() | |||
| } | |||
|
|
|||
| if ($allFailed) { | |||
| throw new AuthLDAP_Exception('No bind successfull'); | |||
There was a problem hiding this comment.
This wording was used deliberately as the library tries multiple binds and none of these is successful.
There was a problem hiding this comment.
Ok I misunderstood the context, 'No bind successful' is a viable alternative :)
| @@ -30,9 +30,9 @@ | |||
| */ | |||
| ?><div class="wrap"> | |||
| <?php if (! extension_loaded('ldap')) : ?> | |||
| <div class="error"><strong>Caveat:</strong> The LDAP-extension is not loaded! | |||
There was a problem hiding this comment.
Why did you remove the strong marking here?
There was a problem hiding this comment.
This was more of a personal opinion, the alert is already inside a
element so it seemed unnecessary to add extra emphasis on any text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.